Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QMR] All Child and Adult Measures - In line warning banner (Data Source) #2239

Merged
merged 13 commits into from
May 29, 2024

Conversation

ajaitasaini
Copy link
Contributor

@ajaitasaini ajaitasaini commented May 17, 2024

Description

Related ticket(s)

CMDCT-3628


How to test

  • Check any adult or child measure in FFY2024, click "Other Data Source" and confirm that a banner is showing up correctly
  • Make sure the banner is not showing up for any health home measure or any measure before 2024
  • special measures to double check: CPA-AD, MSC-AD, CPC-CH

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@ajaitasaini ajaitasaini marked this pull request as ready for review May 20, 2024 13:24
@ailZhou
Copy link
Collaborator

ailZhou commented May 20, 2024

The locations of where you placed the alerts looks to be correct to me and they are showing up. There's just two areas that could use a second look.

  1. Based on the ticket, I think only Other Data Source is suppose to have the warning and not Administrative Data Other
Screenshot 2024-05-20 at 12 45 34 PM 2) This is showing up for all the years but I think we only want this for reporting year 2024 and onward. An example of how we handle only rendering something for a year and not the other can be seen in `OptionalMeasureStrat/index.ts`. If the text key exist in the commonQuestionsLabel.tsx for that year, it will render, if not, it will ignore it. Screenshot 2024-05-20 at 12 53 13 PM

Let me know if anything was confusing or you want a better explanation of anything!

@benmartin-coforma
Copy link
Contributor

I think we'll also need to hit CPA-AD specifically; it has its own version of this question, just like MSC-AD

@ajaitasaini ajaitasaini marked this pull request as draft May 23, 2024 13:18
@ajaitasaini ajaitasaini added the draft Just a draft label May 23, 2024
@ajaitasaini ajaitasaini marked this pull request as ready for review May 23, 2024 15:14
@ajaitasaini ajaitasaini added ready for review Ready for all the reviews! and removed draft Just a draft labels May 23, 2024
karla-vm
karla-vm previously approved these changes May 29, 2024
Copy link

codeclimate bot commented May 29, 2024

Code Climate has analyzed commit 69bcaf7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.9% (0.1% change).

View more on Code Climate.

Copy link
Contributor

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in deployed instance, looks good!

@ajaitasaini ajaitasaini merged commit f9ed348 into master May 29, 2024
21 checks passed
@ajaitasaini ajaitasaini deleted the inline-warning-banner branch May 29, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
6 participants