Add %v, %u and %t parameters to the failover_validation_command #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indicating the number of visible nodes sharing the current upstream, the number of nodes on the current upstream as well as the total number of nodes in the entire repmgr cluster. This allows the failover_validation_command to be used to perform more thorough validations, including cross-referencing external cluster management state (e.g. if managed by kubernetes).
|
Ping |
ibarwick
pushed a commit
that referenced
this pull request
Sep 17, 2020
These indicate: - the number of visible nodes sharing the current upstream - the number of nodes on the current upstream - the total number of nodes in the entire repmgr cluster. This allows the failover_validation_command to be used to perform more thorough validations, including cross-referencing external cluster management state (e.g. if managed by kubernetes). GitHub #651.
|
Finally merged, many thanks. The changes will be included in the 5.2 release, hopefully some time in the next couple of weeks. |
|
Thanks Ian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicating the number of visible nodes sharing the current upstream,
the number of nodes on the current upstream as well as the total
number of nodes in the entire repmgr cluster.
This allows the failover_validation_command to be used to perform
more thorough validations, including cross-referencing external
cluster management state (e.g. if managed by kubernetes).