Code style issues fixed

[krasa]

• explicit super() call, introduced constants from magic strings, moved constants to one place.

[vendethiel]

Shouldn't this use DI so that we can change it at any time?

[krasa]

One thing after another. We could inject those values in the future.

[vendethiel]

make sure to send an email to all of our mailing lists and to each developers' managers

[emiln]

I think this is a very appealing changeset. My one concern is about the many constants residing inside the FizzBuzzTest class. I think it might be worth moving them to a class of constants used for testing. Perhaps simply a Constants class inside the test code, or even TestConstants if we fear ambiguity. With "Testing" being a must win for the company this year, I expect we'll see a regular plethora of additional tests as soon as our QA and Dev teams get started. I imagine we'll then come to regret not having a concise and separate class for just these kinds of constants.

[krasa]

Excellent point, will do.