This fixes the Serial.print commands in the loop block of PCSynch.ino #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the loop section of this sketch, there are a series of commands that print the RTC's time and date to the serial pins. It is updated with the current time every second. The text output is supposed to be (for example):
Current RTC Date/Time: Sunday, April 23, 2017 10:10:10 (1492888806)
When I ran the code after setting the clock, the output was more like:
Current RTC Date/Time: December, April 22112962017 10:10:10 (1492888806)
The source of the non-sense number between month and year was traced one of the Serial.print commands that used single quotes for the string instead of double quotes. I fixed it and the date appears to be printing correctly now.
This is a simple change that doesn't affect how the RTC is set or read. It only changes the printed output for the code.
In the loop section of this sketch, there are a series of commands that print the RTC's time and date to the serial pins. It is updated with the current time every second. The text output is supposed to be (for example):
Current RTC Date/Time: Sunday, April 23, 2017 10:10:10 (1492888806)
When I ran the code after setting the clock, the output was more like:
Current RTC Date/Time: December, April 22112962017 10:10:10 (1492888806)
The source of the bug that printed "December" instead of the day-of-the-week was traced one of the Serial.print commands were we subtracted 1 from now.dayOfWeek(). dayOfWeek already used zero-based indexing for the array (i.e. Sunday was index position 0), so didn't need to have anything subtracted from it. I fixed it and the day of week appears to be printing correctly now.
This is a simple change that doesn't affect how the RTC is set or read. It only changes the printed output for the code.
|
Thank you! |
|
Glad to be a contributor. ... never submitted a pull request before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the PCSynch.ino sketch to set the real time clock (RTC) on my Mayfly board (V0.5) and was confused by the output to the Arduino IDE's serial monitor window. In part, the sketch is supposed to print a user-friendly version of date and time to the Mayfly's serial port every second, but the text in the Arduino serial monitor was slightly garbled. I found errors in two Serial.print commands in the loop() block of the sketch. This pull request only changes the formatting on the serial output in the sketch. It doesn't mess with any of the code that sets or reads data from the RTC or synchronizes with a PC's or time server's clock.
As a side effect, it also fixes the time/date format appearing in the output for PCSynch.exe.