Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.0 specified in ModularSensors but not released #32

Closed
neilh10 opened this issue Dec 27, 2022 · 5 comments
Closed

V4.0 specified in ModularSensors but not released #32

neilh10 opened this issue Dec 27, 2022 · 5 comments

Comments

@neilh10
Copy link

neilh10 commented Dec 27, 2022

For enviroDIY/ModularSensors (develop) library.json specifies
"name": "YosemitechModbus",
"owner": "envirodiy",
"library id": "2078",
"url": "https://github.com/EnviroDIY/YosemitechModbus",
"version": "~0.4.0",

When trying to build I get
Library Manager: Installing envirodiy/YosemitechModbus @ ~0.4.0
Library Manager: Warning! Could not install {'name': 'YosemitechModbus', 'owner': 'envirodiy', 'library id': '2078', 'url': 'https://github.com/EnviroDIY/YosemitechModbus', 'version': '~0.4.0', 'note': 'Arduino library for communication with Yosemitech sensors via Modbus.', 'authors': ['Sara Damiano', 'Anthony Aufdenkampe'], 'frameworks': ['arduino'], 'platforms': ['atmelavr', 'atmelsam']} dependency for theEnviroDIY_ModularSensors package

as EnviroDIY/YosemitechModbus (master) doesn't have a 0.4.0
and needs referencing to (develop) for it to work

Library Manager: Installing git+https://github.com/EnviroDIY/YosemitechModbus#develop

neilh10 pushed a commit to neilh10/ModularSensors that referenced this issue Dec 27, 2022
neilh10 pushed a commit to neilh10/ModularSensors that referenced this issue Dec 27, 2022
neilh10 pushed a commit to neilh10/ModularSensors that referenced this issue Jan 2, 2023
@neilh10
Copy link
Author

neilh10 commented Jan 25, 2023

@aufdenkampe
Copy link
Member

@neilh10, thanks for posting this issue!

I had been waiting merge in v0.4 here:

Until after @SRGDamia1 to issued a new release of Modular sensors with this Pull Request:

In hindsight, my work on YosemitechModbus v0.4 was designed to be backwards compatible, so I'll move forward with PR #31.

@aufdenkampe
Copy link
Member

aufdenkampe commented Jan 25, 2023

@neilh10, I just merged PR #31 and issued a release.

PlatformIO's Library Registry should auto-update in the next day or so. See:
https://registry.platformio.org/libraries/envirodiy/YosemitechModbus

Once it shows v0.4.0, your problem should be fixed. Let me know.

@neilh10
Copy link
Author

neilh10 commented Jan 26, 2023

thanks for the update - will try it.

From past projects being clear how code is promoted takes a bit of thinking about, and there needs to be sand box to play around in. Hard to get it perfect straight away.

I think of (develop) https://github.com/EnviroDIY/ModularSensors/tree/develop as being where everything is worked on, prototyped, so slightly risky.

So that was the case in just finding that
as EnviroDIY/YosemitechModbus (master) doesn't have a 0.4.0
and needs referencing to EnviroDIY/YosemitechModbus (develop) for it to work

I typically try and merge from EnviroDIY/ModularSensors (master) to my development branch
neilh10/ModularSensors (rel1_dvlp1m) and then test there.
However in this case, because there was a lot on EnviroDIY/ModularSensors (develop), so I pulled in the updates onto my development branch neilh10/ModularSensors (rel1_dvlp1m), and the lib reference broke it,
but was easy to work around.

Many thanks

@neilh10
Copy link
Author

neilh10 commented Feb 8, 2023

Testing in my environment - works to pull from https://github.com/EnviroDIY/YosemitechModbus

@neilh10 neilh10 closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants