Addressing issue 1304 of malformed definition source links

[ddooley]

Removed definition source links which were all of form
42169:AnnotationAssertion(Annotation(http://www.geneontology.org/formats/oboInOwl#hasDbXref http://purl.obolibrary.org/obo/ENVO_) ...

[kaiiam]

This looks good to me thanks @ddooley for manually cleaning this up! @cmungall @wdduncan @pbuttigieg I think this is good to merge.

[wdduncan]

@ddooley I also noticed that the classes you added use the created_by annotation. The wiki says to use dc:creator. Although, I think this should say dcterms:creator.

What is your opinion @kaiiam @pbuttigieg

[cmungall]

Let's merge ASAP. This fixes a semi-urgent technical issue with a previous PR

Let's carry forward discussion of the precise wording of definitions into a new issue/PR

[kaiiam]

Thanks @wdduncan everything you identified could be cleaned up as you describe but as @cmungall said it's not an urgent technical fix. I'd say if someone has scope to clean this quickly before merging great if not as @cmungall says we should perhaps just merge.

[wdduncan]

@cmungall @kaiiam I understand what you are saying, but I worry that if the issues aren't addressed now, they never will be. The fixes don't seem that difficult.

@ddooley How long do you think it would take to address them?

[kaiiam]

Fair point @wdduncan if @ddooley you can quickly address Bill's comments above that would be ideal!

[ddooley]

i can do the last changes this afternoon directly on the OWL file. I didn't realize yesterday that you'd provided a whole batch of feedback, Duncan, much appreciated!

[wdduncan]

Thanks for getting to this so quickly @ddooley !!!

We'll merge the merge once your finished :)

[ddooley]

About the "created_by" annotation, I'm seeing quite a number of entries have this besides the ones I recently added. If you want to normalize created_by to dc/terms:creator I'm fine with that but lets do that as a separate pr for bulk search and replace?!
That said, I think its ready to merge.

[kaiiam]

Looks good @ddooley. I agree we should deal with the created_by APs in bulk as we have multiple APs in use at the moment.

[wdduncan]

Thanks for edit @ddooley !
PR merged :)

[kaiiam]

Thanks @wdduncan!