Periphytic biofilm subclasses #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I copied and pasted the definition from the parent class. Unnecessary duplication? I haven't added any axioms/logical definitions |
aclum
approved these changes
Jan 2, 2024
cmungall
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
I'm approving this but there is a slight technical issue. For the rest of ENVO we are following norms in GO, CL, Uberon, etc where we place definition source as an axiom annotation on the definition. There may be an issue with the robot template configuration. I'll make a separate issue
cmungall
reviewed
Jan 2, 2024
| @@ -44939,6 +44944,36 @@ AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03605000> | |||
| AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03605000> "periphytic biofilm"@en) | |||
| SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03605000> <http://purl.obolibrary.org/obo/ENVO_01000156>) | |||
|
|
|||
| # Class: <http://purl.obolibrary.org/obo/ENVO_03605001> (epilithon) | |||
|
|
|||
| AnnotationAssertion(Annotation(<http://purl.obolibrary.org/obo/IAO_0000119> "NEON.DOC.003044, revision E, title AOS Protocol and Procedure: AMC – Aquatic Microbial Sampling in https://data.neonscience.org/documents/10179/1883159/NEON.DOC.003044vE/05ca8fcc-33ba-a5b2-0e93-8f4001f38c37") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03605001> "Periphyton colonizing rock substrata") | |||
There was a problem hiding this comment.
this isn't how we do definition sources in the rest of envo
There was a problem hiding this comment.
this isn't how we do definition sources in the rest of envo
Isn't that what I did?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.