mark strcmp as inactive2 (rust-lang#716)

* mark strcmp as inactive2 * mark strcmp as inactive3 * mark strcmp as ro * mark Fn too
EnzymeAD · Jun 26, 2022 · 5d5ee10 · 5d5ee10
1 parent 3316e62
commit 5d5ee10
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/enzyme/Enzyme/Enzyme.cpp b/enzyme/Enzyme/Enzyme.cpp
@@ -1560,6 +1560,12 @@ class Enzyme : public ModulePass {
             Fn->getName() == "__mth_i_ipowi") {
           CI->addAttribute(AttributeList::FunctionIndex, Attribute::ReadNone);
         }
+        if (Fn->getName().contains("strcmp")) {
+          Fn->addParamAttr(0, Attribute::ReadOnly);
+          Fn->addParamAttr(1, Attribute::ReadOnly);
+          Fn->addFnAttr(Attribute::ReadOnly);
+          CI->addAttribute(AttributeList::FunctionIndex, Attribute::ReadOnly);
+        }
         if (Fn->getName() == "f90io_fmtw_end" ||
             Fn->getName() == "f90io_unf_end") {
           Fn->addFnAttr(Attribute::InaccessibleMemOnly);

diff --git a/enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp b/enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp
@@ -4039,6 +4039,14 @@ void TypeAnalyzer::visitCallInst(CallInst &call) {
                      &call);
       return;
     }
+    if (funcName == "strcmp") {
+      updateAnalysis(&call, TypeTree(BaseType::Integer).Only(-1), &call);
+      updateAnalysis(call.getOperand(0), TypeTree(BaseType::Pointer).Only(-1),
+                     &call);
+      updateAnalysis(call.getOperand(1), TypeTree(BaseType::Pointer).Only(-1),
+                     &call);
+      return;
+    }
     if (funcName == "bcmp") {
       updateAnalysis(&call, TypeTree(BaseType::Integer).Only(-1), &call);
       updateAnalysis(call.getOperand(0), TypeTree(BaseType::Pointer).Only(-1),