-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize output into logical subfolders #44
Conversation
e42ebd7
to
f7e61a8
Compare
d947426
to
db67dd5
Compare
fixes issue #19 |
b5885ec
to
4fd4558
Compare
4fd4558
to
9e7d4c2
Compare
My vote is for 2. 1 sounds like it could get confusing fast. |
The option 1 sounds like it would be confusing work from a development side. If a users folder is so large that option 2 causes massive bloating I think it is reasonable to assume they can handle removing files as necessary. |
I'm in agreement with Matt and Ruby. Having a program dynamically find files and move them around makes me nervous. |
I agree with everyone upstairs. I prefer option 2 too. |
Ok, thank you all for the input. I believe I have it all working properly now, including for difference and ratio plots. When you re-run ps_wrapper on an old folder, the DFT and power spectra should not be recalculated, but it will redo the binning (which is pretty fast). Existing files will not be moved, but any new files that are written will be written to the new locations. Files that are read but not recalculated will be left in the old location and not copied to the new location. Difference and Ratio plots should run on any combination of new and old folders with no need to rerun anything. I have tested it some on my own, but I'd love for some volunteers to do some real-world testing and make sure I haven't added any new bugs. |
Any objections to my merging this? @nicholebarry @rlbyrne @mkolopanis @wenyang-li @adampbeardsley |
I say go for it!
On Tue, Feb 27, 2018 at 4:02 PM Bryna Hazelton ***@***.***> wrote:
Any objections to my merging this? @nicholebarry
<https://github.com/nicholebarry> @rlbyrne <https://github.com/rlbyrne>
@mkolopanis <https://github.com/mkolopanis> @wenyang-li
<https://github.com/wenyang-li> @adampbeardsley
<https://github.com/adampbeardsley>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEiGFU9fQmZXVrF1VdvvoUT0rQjFjgf2ks5tZImWgaJpZM4RsMdc>
.
--
Adam Beardsley
National Science Foundation Fellow
Arizona State University
School of Earth and Space Exploration
Low Frequency Cosmology
Homepage: loco.lab.asu.edu/adam_beardsley
|
Fine by me! |
Ditto. |
This branch reorganizes the output of eppsilon into the following folders:
data
plots
It is not yet backwards compatible, I have some questions about what users want for backwards compatibility. I think there are two options:
I'd like to get feedback from users about which of these options they prefer.
@adampbeardsley @nicholebarry @rlbyrne @mkolopanis