Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MCPUK uploaded filenames cleaning based on standard TransAlias plugin…
… (common transliteration)
- Loading branch information
cd5604aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Git seems to be being somewhat unclear as to which lines have changed. Am I right in thinking this commit involves just the addition of cleanFilename() and it's call from run() ?
-- Tim.
cd5604aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, its by no means "complete" solution (hardcoded loading of common transliteration). Don't know why GitHub decided to show all lines as removed/added again?
cd5604aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked through it all (!) but line 43 (old) and line 77 (new) may give a clue. The line has not been changed but has been reformatted. I know many take the view that reformatting of existing code for the sake of consistency or 'code standards' is good, but it makes life difficult when using version control programs that use diff as they see such changes as coding changes.
That may not explain everything though. The only other possibility I can think of is whether there is some issue regarding windows/unix line feeds.