New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw body support for application/ld+json and application/activity+json #59

Merged

Eomm merged 5 commits into Eomm:main from perillamint:fix/json-subtype

Nov 16, 2023

Contributor

perillamint commented Nov 14, 2023

This PR implements raw body support for application/ld+json and application/activity+json


          Raw body support for application/ld+json and application/activity+json

d3b6584

perillamint closed this

Owner

Eomm commented Nov 16, 2023

Thanks for the PR

Why it is closed now?

Contributor Author

perillamint commented Nov 16, 2023 •

edited

Loading

I found it causes some trouble with preexisting handlers in some cases. For example: misskey-dev/misskey@04075ee

I think this should be handled in a better way (or should state that it breaks some compatibility)

perillamint reopened this

perillamint marked this pull request as draft

November 16, 2023 07:54

Contributor Author

perillamint commented Nov 16, 2023

I re-opened it but put it in draft state

Owner

Eomm commented Nov 16, 2023

I think this should be handled in a better way (or should state that it breaks some compatibility)

The best approach would be to accept a new user's config to set the content type.

Please, add some tests too

perillamint marked this pull request as ready for review

November 16, 2023 09:07

Contributor Author

perillamint commented Nov 16, 2023

Done! Could you review this patch set? @Eomm

perillamint added 3 commits

November 16, 2023 18:09


          Accept content-type overrides using jsonContentTypes option


          Implement test for alternative content-type header

4058c95


          Document jsonContentTypes option

b7027f7

perillamint force-pushed the fix/json-subtype branch from 58e9628 to b7027f7 Compare

November 16, 2023 09:10

Eomm reviewed

View reviewed changes

plugin.js Outdated Show resolved Hide resolved


          Update plugin.js

05e01b5

Eomm approved these changes

View reviewed changes

Eomm merged commit d7c15db into Eomm:main

19 checks passed

renovate bot added a commit to redwoodjs/redwood that referenced this pull request


          fix(deps): update dependency fastify-raw-body to v4.3.0 (#9566)

58b3758

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify-raw-body](https://togithub.com/Eomm/fastify-raw-body) |
[`4.2.2` ->
`4.3.0`](https://renovatebot.com/diffs/npm/fastify-raw-body/4.2.2/4.3.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify-raw-body/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify-raw-body/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify-raw-body/4.2.2/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify-raw-body/4.2.2/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Eomm/fastify-raw-body (fastify-raw-body)</summary>

###
[`v4.3.0`](https://togithub.com/Eomm/fastify-raw-body/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/Eomm/fastify-raw-body/compare/v4.2.2...v4.3.0)

#### What's Changed

- chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#53
- chore(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#56
- chore(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#58
- Raw body support for application/ld+json and application/activity+json
by [@&#8203;perillamint](https://togithub.com/perillamint) in
[Eomm/fastify-raw-body#59

#### New Contributors

- [@&#8203;perillamint](https://togithub.com/perillamint) made their
first contribution in
[Eomm/fastify-raw-body#59

**Full Changelog**:
Eomm/fastify-raw-body@v4.2.2...v4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

jtoar pushed a commit to redwoodjs/redwood that referenced this pull request


          fix(deps): update dependency fastify-raw-body to v4.3.0 (#9566)

e153b50

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify-raw-body](https://togithub.com/Eomm/fastify-raw-body) |
[`4.2.2` ->
`4.3.0`](https://renovatebot.com/diffs/npm/fastify-raw-body/4.2.2/4.3.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify-raw-body/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify-raw-body/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify-raw-body/4.2.2/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify-raw-body/4.2.2/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Eomm/fastify-raw-body (fastify-raw-body)</summary>

###
[`v4.3.0`](https://togithub.com/Eomm/fastify-raw-body/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/Eomm/fastify-raw-body/compare/v4.2.2...v4.3.0)

#### What's Changed

- chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#53
- chore(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#56
- chore(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#58
- Raw body support for application/ld+json and application/activity+json
by [@&#8203;perillamint](https://togithub.com/perillamint) in
[Eomm/fastify-raw-body#59

#### New Contributors

- [@&#8203;perillamint](https://togithub.com/perillamint) made their
first contribution in
[Eomm/fastify-raw-body#59

**Full Changelog**:
Eomm/fastify-raw-body@v4.2.2...v4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

bodinsamuel pushed a commit to specfy/specfy that referenced this pull request


          fix(deps): update dependency fastify-raw-body to v4.3.0 (#396)

3a2ca4a

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify-raw-body](https://togithub.com/Eomm/fastify-raw-body) |
[`4.2.2` ->
`4.3.0`](https://renovatebot.com/diffs/npm/fastify-raw-body/4.2.2/4.3.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify-raw-body/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify-raw-body/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify-raw-body/4.2.2/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify-raw-body/4.2.2/4.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Eomm/fastify-raw-body (fastify-raw-body)</summary>

###
[`v4.3.0`](https://togithub.com/Eomm/fastify-raw-body/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/Eomm/fastify-raw-body/compare/v4.2.2...v4.3.0)

#### What's Changed

- chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#53
- chore(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#56
- chore(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Eomm/fastify-raw-body#58
- Raw body support for application/ld+json and application/activity+json
by [@&#8203;perillamint](https://togithub.com/perillamint) in
[Eomm/fastify-raw-body#59

#### New Contributors

- [@&#8203;perillamint](https://togithub.com/perillamint) made their
first contribution in
[Eomm/fastify-raw-body#59

**Full Changelog**:
Eomm/fastify-raw-body@v4.2.2...v4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment