-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for compatibility with recent/pending core EpiModel changes #35
Conversation
@smjenness some questions related to this:
|
there's no direct precedent for this setup in core EpiModel, but I think using the first resimulated network index minus one is reasonable
use depart_nodes in EpiModelCOVID
use arrive_nodes in EpiModelCOVID
netsim_dat class documentation updates
Note that this PR includes updates for |
Thanks! |
closes #34
Some notes:
since
summary_nets
is a separate module, it must be included in themodule.order
argument (in the EpiModelCOVID tests); this requirement could be eliminated by instead callingsummary_nets
at the end of the resimulation module (where nwstats were formerly obtained); since there is already an issue for moving nwstats to the prevalence module (move the nwstats calculation to the prevalence module EpiModel#811) I'm not planning to move it into the resimulation moduleEpiModelCOVID initialization modules now perform network resimulation at time 1, consistent with core EpiModel
vertex attributes are now copied to dat using copy_nwattr_to_datattr (within init_nets), which differs slightly in what vertex attributes it excludes as compared to the previous copying mechanism in EpiModelCOVID initialization