Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, when combined with #106 and #107, resolves all displayed compiler warnings for our given dependency state.
We do have some areas of code that are missing docs. As a result, I commented out many
#[warn(missing_docs)]
directives in code.All of these were performed in this commit (line highlighted for demonstration in diff): acc157e#diff-27f4d3db6f3d4186c01baf2c708602ed942e2c994e0aaf61f822c246ef477b5dR22
While not urgent, we should go through and uncomment each of these, and add docs that are missing.
Then, Epic can be published as a crate, for use by CypherStack and others, accompanied by worthy documentation.
Details on warnings these commits resolve:
These changes were cross-referenced with Grin upstream, to emulate their choices of replacement functions.
in
core/src/core/id.rs
:in
chain/src/store.rs
:These were resolved by removing duplicate conditions that set
prev_header = None
.None
is now default value, so we only populate it on successfulif
evaluation.else
conditions are irrelevant here.in
src/bin/tui/mining.rs
:There were a lot of these warnings to resolve, but they boil down to 2 separate ones, really. Examples provided below, but shown once for brevity.