Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Compiler Warnings #108

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Resolve Compiler Warnings #108

merged 3 commits into from
Sep 28, 2023

Commits on Sep 28, 2023

  1. Update zip dep to 0.5.11, resolve deprecated function warnings 

    - These features have been deprecated since 0.5.7 of zip package
- Changes pulled from mimblewimble/grin@1b8acee
    @who-biz
    who-biz committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3b58407 View commit details
    Browse the repository at this point in the history

  2. Resolve various warnings 

    core/src/core/id.rs:
- We have documentation annotated macros that do Rust does not generate docs for

chain/src/store.rs:
- Resolves unused assignment warnings
  - These are resolved by removing no-operation conditions within 'else' branches.
  - Instead, we initialize 'prev_header' with 'None', and only populate on successful bool = true

src/bin/tui/mining.rs:
- Comment out variants in Mining tables that are never constructed
- Looks like they were removed due to size constraints of TUI, Rust doesn't like the variants being present when not used
    @who-biz
    who-biz committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    88743b1 View commit details
    Browse the repository at this point in the history

  3. Resolve deprecation warnings for DateTime, TimeZone functions 

    - DateTime implementations are no longer the proper way to do much to the time operations
- Instead, we use TimeZone::from_utc_datetime, which has same return type... Just semantic changes mostly
    @who-biz
    who-biz committed Sep 28, 2023
    2 Configuration menu
    Copy the full SHA
    4179d5b View commit details
    Browse the repository at this point in the history