This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Bring smaller bundle size fix to 5.2 (#117) #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed Github actions to first do `npm ci`, then `npm link` * Modified package to not bundle library dependencies into library JS * Added: webpack config to build both umd and esm versions of the frontend library * Changed package run to first do `npm ci`, then `npm link` also for implementation, since now it has the libraries as dependencies * Updated package-lock * Switch the order of `npm link` commands because the order matters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Github actions to first do
npm ci, thennpm linkModified package to not bundle library dependencies into library JS
Added: webpack config to build both umd and esm versions of the frontend library
Changed package run to first do
npm ci, thennpm linkalso for implementation, since now it has the libraries as dependenciesUpdated package-lock
Switch the order of
npm linkcommands because the order matters