This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Security updates for default turn server configuration. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The default turn server configuration has a serious security vulnerability allowing internal network traversal from an external entity.
Solution
This change introduces a set of configuration options in a config file that will close off traversal to certain subnets.
Documentation
NA
Test Plan and Compatibility
Running the existing with-turn or turn scripts on windows/linux/docker should now mention that it loaded a config file and dump out a list of the blocked subnets and whitelist local TURN ip.