This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Re-enable iOS and iPadOS fullscreen #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… webplayer in iOS.
|
Hey @copostic, As mentioned in the PR, iOS will still use the native player regardless of whether you're using the typescript frontend or the js frontend in 5.1 and earlier. That being said, I'll look at bringing the user agent check which will allow full screen on iPads into the older branches tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
This issue addresses #258, which states full screen on iOS has been broken since moving to the typescript frontend.
This regression is caused by iOS only allowing video elements to be full screened, whereas iPad and all other devices allow arbitrary html elements to become full screen. source
Solution
This PR addresses the problem by first checking the browsers user agents and if the device is an iPod or iPhone, we will only full screen the video element, otherwise we will full screen the parent div which contains all of the interactable UI.
NOTE: As previously described, iPhones and iPods can't full screen arbitrary elements and as such requesting full screen will result in the video being played through the native player and input being prevented.
Test Plan and Compatibility
Tested on an iPhone and iPad to confirm correct operation between devices.