This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Include create, reconnect, and update events (with associated tests) #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please feel free to provide your feedback and suggestions, especially with the tests; they're a top weakness of mine |
itsjayway
changed the title
lukehb
reviewed
Jun 16, 2023
lukehb
reviewed
Jun 16, 2023
lukehb
previously requested changes
Jun 16, 2023
|
no worries—pushed! |
mcottontensor
approved these changes
Jun 20, 2023
mcottontensor
approved these changes
Jun 21, 2023
| pixelStreaming.disconnect(); | ||
| pixelStreaming.connect(); | ||
|
|
||
| expect(streamReconnectSpy).toHaveBeenCalled(); |
There was a problem hiding this comment.
This appears to be failing tests. I believe because reconnect isn't being called since connect is manually immediately called.
There was a problem hiding this comment.
ah, my mistake, thank you for fix!
mcottontensor
added a commit
that referenced
this pull request
Jun 21, 2023
…d-CRD-events Include create, reconnect, and update events (with associated tests)
mcottontensor
added a commit
that referenced
this pull request
Jun 21, 2023
…d-CRD-events Include create, reconnect, and update events (with associated tests)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
#270
Solution
uses contextual structure of methods and events to add the new events
Documentation
WIP
Test Plan and Compatibility
event emitters should not affect functionality; implementation of these functions are complemented by the new tests