This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix iOS touch when settings panel is open #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… webplayer in iOS
…ttributes not respecting the webkit prefix
lukehb
changed the title
|
removing the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Touch events weren't routed to panels once a video had started playing. This prevented modification of settings that we're not visible as you couldn't scroll to see them.
Solution
Remove the passive aspect from touch handlers. This may have some negative impact on page performance but is necessary as the listeners we registers aren't passive.
Test Plan and Compatibility
Tested on mobile platforms to ensure fix as well as desktop platforms to ensure no regressions