This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Show player count in stats panel #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belchy06
added
enhancement
|
The player count currently just tracks the number of players that connect to the signalling server. With the ability to handle multiple streamers now this count may be misleading if there are multiple streamers connected. |
|
Hmm, good point. I think with that fact there may need to be some more though put into this. That being said, I think we can get this landed and look to moving to players per stream as part of the great signalling server refactor. Thoughts? |
|
Yeah landing this can still be of use. We will just need an enhancement issue added to track the players per stream work. |
mcottontensor
approved these changes
Jul 18, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit 6bdbf50)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit 6bdbf50)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Belchy06
added a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit 6bdbf50) Co-authored-by: William Belcher <william.belcher@xa.epicgames.com>
Belchy06
added a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit 6bdbf50) Co-authored-by: William Belcher <william.belcher@xa.epicgames.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Player count information is simply logged to the developer console but is never shown in any UI, making it harder for non-technical users to view this information as reported in #302
Solution
Add a new
playerCountevent that user's can listen to. By default, UI Library will listen for this event and update the value in the stats panel.