This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Ensure touch is relative to absolute location of parent rect #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belchy06
added
auto-backport
auto-backport-to-UE5.2
auto-backport-to-UE5.3
bug
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit 4e370e5)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit 4e370e5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Belchy06
pushed a commit
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit 4e370e5) Co-authored-by: Michael Stopa <michael.stopa@xa.epicgames.com>
Belchy06
pushed a commit
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit 4e370e5) Co-authored-by: Michael Stopa <michael.stopa@xa.epicgames.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
#287
Solution
Fixes #287 by making touch coordinates be relative to the viewport's absolute bounding rect rather than its own stated offset
Test Plan and Compatibility
Uses a different class member to retrieve the video element's offset on screen, but the underlying logic is identical.
Tested by streaming a plain 3rd person project to an Android phone that previously reproduced the problem stated above.