This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Have matchmaker ask for authentication instead of erroring out with EACCESS #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added executable flags to bash scripts for SFU and Matchmaker.
StomyPX
added a commit
to StomyPX/PixelStreamingInfrastructure
that referenced
this pull request
Jul 26, 2023
Belchy06
changed the title
Belchy06
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added executable flags to bash scripts for SFU and Matchmaker.
Relevant components:
Problem statement:
Unlike the SFU and Signalling Server, the Matchmaker errors out when not run with superuser permissions.
Solution
Modified the Matchmaker to ask for privileges the same way that the SFU and Signalling Server do. Also added executable permissions to all the SFU and Matchmaker bash scripts to make them immediately useful the way the Signalling Server scripts are.
Test Plan and Compatibility
I've confirmed that it works on Linux, somebody should try it out on Windows to make sure there aren't any typos or anything. But otherwise it looks more or less like how the SFU and Signalling Server do it so everything should be good.