This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Refactor SignallingWebServer to a single docker file #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic version in /SignallingWebServer
6 tasks
StomyPX
approved these changes
Jul 27, 2023
This was referenced Jul 27, 2023
Belchy06
added a commit
that referenced
this pull request
Jul 27, 2023
Belchy06
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
There currently exists two dockerfiles for the SignallingWebServer. One in the parent directory and one in
platform_scripts/bash.Solution
This PR removes the dockerfile from
platform_scripts/bashand merges some of its contents to the file located in the parent directory.Test Plan and Compatibility
Tested
docker-build-cirrus.shto ensure that images can still be built and then launched the script withdocker-start-cirrus.shto ensure we can still launch correctly.