This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Dockerfile for SFU #431
Merged
Dockerfile for SFU #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehb
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Looks good, one thing is, let's get a github workflow as part of this PR to auto build this image and push it to the official containers, much like this one: https://github.com/EpicGames/PixelStreamingInfrastructure/blob/master/.github/workflows/container-images.yml
|
Actually the docs on the front page should change if we do ship a container on the SFU too. |
…iner reference on main README.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
There was an old Dockerfile in the repo but it was old and in a slightly different location to other components of infra.
Additionally there were some errors in the bash platform_scripts that prevented it from building the frontend.
Solution
Updates the Dockerfile and moves it into the expected location.
Also updated the platform_scripts for bash to properly pass arguments around.
Documentation
Will add docker instructions to the SFU documentation in another PR when the previous docs PR is in.
Test Plan and Compatibility