Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Small signalling server fixes. #443

Merged
merged 2 commits into from Dec 10, 2023

Conversation

mcottontensor
Copy link
Contributor

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Two issues:

  • Some logging calls like console.warn and console.error were not captured by the logging system and thus were not logged to files.
  • If a streamer disconnected before it identified itself the id timer was never cleared and so a bad legacy name would be added and left behind.

Solution

  • Added extra handlers for console.warn and console.error to properly log them.
  • Cleared any id timer on streamer disconnect.

Fixes #439

mcottontensor and others added 2 commits November 29, 2023 12:02
…g the signalling server would create a legacy name that would be left behind.

Fixing some logging calls that would not properly be handled by the logging system.
@mcottontensor mcottontensor merged commit 4ebc522 into EpicGames:master Dec 10, 2023
@mcottontensor mcottontensor deleted the stale_legacy_timer branch December 10, 2023 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Signalling Server logging missing some messages
1 participant