This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Re-order settings order #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial settings -> url params
mcottontensor
approved these changes
Jan 15, 2024
cheikhnadiouf
pushed a commit
to cheikhnadiouf/PixelStreamingInfrastructure
that referenced
this pull request
Feb 15, 2024
…ial settings -> url params (EpicGames#471)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move settings order so that they are parsed in the following order:
Relevant components:
Problem statement:
Addresses #467
Solution
This PR changes the default value when creating the setting object to either be the initial setting value or the default value. Doing it this specific way prevents extra events being emitted about settings being changes.
Test Plan and Compatibility
Tests still work