Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Remove Unreal version from cirrus log #484

Closed
wants to merge 1 commit into from

Conversation

timbotimbo
Copy link
Contributor

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

The master, 5.5 and 5.4 branches still log that Cirrus is for Unreal 5.3
Running Cirrus - The Pixel Streaming reference implementation signalling server for Unreal Engine 5.3

Solution

As this version number isn't very important and it has proven easy to forget on updates, just remove it.
Running Cirrus - The Pixel Streaming reference implementation signalling server for Unreal Engine

Documentation

N / A

Test Plan and Compatibility

N / A

Signed-off-by: timbotimbo <timbotimbo@users.noreply.github.com>
@lukehb
Copy link
Contributor

lukehb commented Feb 15, 2024

@timbotimbo We had a chat internally, yep, we think removing it is okay. What we doing right now is working on #10 - so there will be a completely new Cirrus soon anyway so we are not too concerned about removing the version logging from the existing Cirrus. In the new Cirrus we are thinking we will log the package.json version of the signalling server, as this is useful for debugging, but not mention any specific pairing with a version of UE.

CC @mcottontensor As a note to add the proposed logging of version number into the new cirrus.

@lukehb lukehb closed this Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants