Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload unit tests2 #330

Merged
merged 8 commits into from
Jun 16, 2021
Merged

File upload unit tests2 #330

merged 8 commits into from
Jun 16, 2021

Conversation

mgstauffer
Copy link
Contributor

Unit tests should be finished now.
The issue with the enzyme snapshot inconsistency between local machine and github actions is resolved by running the local unit tests using docker-compose instead of via an attached process.
The issue with github actions not properly catching an error in unit tests is resolved by properly returning exit values in unit tests scripts.

This should finish #262

Direct access tests mostly done for feature specification code.
Working on tests for text-based feature specification.
Ordinal feature specification text input tests.
Needed for proper error handling in Github Actions
NO Enzyme Snapshot for js_tests.sh
Remove the untested method of fine control via env vars. Move to
separate branch to work on separately.
@mgstauffer mgstauffer merged commit 8a5124f into master Jun 16, 2021
@mgstauffer
Copy link
Contributor Author

Merged per approval from Heather

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant