Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we rename optimize() to fit()? #12

Closed
rhiever opened this issue Nov 12, 2015 · 1 comment
Closed

Should we rename optimize() to fit()? #12

rhiever opened this issue Nov 12, 2015 · 1 comment
Assignees
Labels

Comments

@rhiever
Copy link
Contributor

rhiever commented Nov 12, 2015

@rasbt, what do you think? We basically have a normal-ish sklearn interface here except for the optimize() call.

@rasbt
Copy link
Contributor

rasbt commented Nov 12, 2015

In practice, I think it really doesn't matter ... However, it's probably not a bad idea down the road to ensure compatibility with scikit-learn functions. E.g., maybe you'd want to use it in a wrapper function like cross_val_score or so later on. Since it doesn't hurt, I'd recommend renaming it to fit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants