Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more feature selection operators #45

Closed
4 tasks done
rhiever opened this issue Dec 5, 2015 · 7 comments
Closed
4 tasks done

Add more feature selection operators #45

rhiever opened this issue Dec 5, 2015 · 7 comments

Comments

@bartleyn
Copy link
Contributor

bartleyn commented Dec 5, 2015

Would these be options that fall under the _dt_feature_selection method?

@rhiever
Copy link
Contributor Author

rhiever commented Dec 5, 2015

Nope - these will be separate functions.

On Friday, December 4, 2015, Nathan notifications@github.com wrote:

Would these be options that fall under the _dt_feature_selection method?


Reply to this email directly or view it on GitHub
#45 (comment).

Randal S. Olson, Ph.D.
Postdoctoral Researcher, Institute for Biomedical Informatics
University of Pennsylvania

E-mail: rso@randalolson.com | Twitter: @randal_olson
https://twitter.com/randal_olson
http://www.randalolson.com

@bartleyn
Copy link
Contributor

bartleyn commented Dec 5, 2015

Right, duh, because dt stands for decision tree. These operators would then act as alternatives to _dt_feature_selection. I'd be interested in taking a stab at it tonight/this weekend.

@rhiever
Copy link
Contributor Author

rhiever commented Dec 5, 2015

Awesome. I'll keep an eye out for the PR!

On Friday, December 4, 2015, Nathan notifications@github.com wrote:

Right, duh, because dt stands for decision tree. These operators would
then act as alternatives to _dt_feature_selection. I'd be interested in
taking a stab at it tonight/this weekend.


Reply to this email directly or view it on GitHub
#45 (comment).

Randal S. Olson, Ph.D.
Postdoctoral Researcher, Institute for Biomedical Informatics
University of Pennsylvania

E-mail: rso@randalolson.com | Twitter: @randal_olson
https://twitter.com/randal_olson
http://www.randalolson.com

@rhiever
Copy link
Contributor Author

rhiever commented Dec 7, 2015

@bartleyn, just wanted to ping you about this one to see if you're working on it. If not, I'll likely try to tackle this issue this week.

@bartleyn
Copy link
Contributor

bartleyn commented Dec 7, 2015

Was actually about to submit my PR -- I've gotten all four to work as additional operators, but could probably use some optimization (no caching, etc). Also could probably abstract a couple additional things.

@rhiever
Copy link
Contributor Author

rhiever commented Dec 7, 2015

Woohoo! 👍

In your PR, please note what operators are slow (and how they can be optimized) and how else the code can be improved so we can file them as PRs or fix them on the spot.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants