-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more feature selection operators #45
Comments
Would these be options that fall under the _dt_feature_selection method? |
Nope - these will be separate functions. On Friday, December 4, 2015, Nathan notifications@github.com wrote:
Randal S. Olson, Ph.D. E-mail: rso@randalolson.com | Twitter: @randal_olson |
Right, duh, because dt stands for decision tree. These operators would then act as alternatives to _dt_feature_selection. I'd be interested in taking a stab at it tonight/this weekend. |
Awesome. I'll keep an eye out for the PR! On Friday, December 4, 2015, Nathan notifications@github.com wrote:
Randal S. Olson, Ph.D. E-mail: rso@randalolson.com | Twitter: @randal_olson |
@bartleyn, just wanted to ping you about this one to see if you're working on it. If not, I'll likely try to tackle this issue this week. |
Was actually about to submit my PR -- I've gotten all four to work as additional operators, but could probably use some optimization (no caching, etc). Also could probably abstract a couple additional things. |
Woohoo! 👍 In your PR, please note what operators are slow (and how they can be optimized) and how else the code can be improved so we can file them as PRs or fix them on the spot. Cheers! |
Add more feature selection operators from sklearn:
The text was updated successfully, but these errors were encountered: