Fix _pre_test
hanging when generating candidates
#1024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #1023
We added a time out to the pipeline
.fit
call.Running the below on the original codebase should hang, while the patched version should complete as expected.
Note that I chose a timeout of 2 seconds in the patch (an arbitrary choice). I leave the choice of this to the maintainers, who are likely to have a better sense of a reasonable value.
Questions:
Do the docs need to be updated?
No
Does this PR add new (Python) dependencies?
No