Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored export utils' generate_import_code function #131

Merged
merged 1 commit into from
May 8, 2016
Merged

Refactored export utils' generate_import_code function #131

merged 1 commit into from
May 8, 2016

Conversation

danthedaniel
Copy link
Contributor

What does this PR do?

Begins the long journey of refactoring and cleaning up the export_utils module. Here I've refactored the generate_import_code function so that it treats data as data by placing all import statements for different operators/preprocessors into a dict.

The import code generated should also be much cleaner, as it will transform previous imports of the form:

from module.name import OperatorA
from module.name import OperatorB

into:

from module.name import OperatorA, OperatorB

And duplicate imports are not possible either

Where should the reviewer start?

In the export_utils.py module at the generate_import_code function.

How should this PR be tested?

I would recommend comparing the import statements in exported pipelines between this codebase and the existing codebase to verify they are equivalent.

Any background context you want to provide?

No

What are the relevant issues?

None

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated?

No

  • Does this PR add new (Python) dependencies?

No

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 28.808% when pulling 9edff29 on teaearlgraycold:eu_imports_ref into 8417028 on rhiever:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants