remove deprecated imp, fix docstring warning #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention this issue was brought up in #1327 |
|
The suggested fix seems to work, but the Python docs suggest using importlib instead of imp. |
jay-m-dev
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
The Python docs recommend using importlib instead of the imp package. However, upon further research and testing types.ModuleType works here as well. There's no clear benefit of using one over the other.
Accepting this update as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imp is deprecated in Python 12. This was only used in one function which I replaced with the equivalent function found in the types module.
Also, the docstrings that contained backslashes were causing a warning to be called every time that was imported. These were probably intended for latex formatting, but Python reads them differently. I turned those into literal docstrings so that the Python interpretation of escape sequences was ignored, which stopped the warnings.