Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect exception raise in import code generation function #138

Merged
merged 2 commits into from
May 10, 2016
Merged

Removed incorrect exception raise in import code generation function #138

merged 2 commits into from
May 10, 2016

Conversation

danthedaniel
Copy link
Contributor

What does this PR do?

Removes the RuntimeError exception that is raised when no import statements are defined for a pipeline operator

Where should the reviewer start?

Line 164 in tpot/export_utils.py

How should this PR be tested?

Currently the master branch will throw an exception if an exported pipeline uses any operators that don't require any imports (like _combine_dfs()). That behavior can be seen in the existing codebase, and can be tested in the teaearlgraycold/eu_imports_ref codebase to see that it does not persist.

Questions:

  • Do the docs need to be updated?

No

  • Does this PR add new (Python) dependencies?

No


Instead of removing the exception I could alternatively require people to enter blank dicts for operators that do not require import statements, but that seems less preferable.

Daniel added 2 commits May 9, 2016 18:15
Merge with rhiever/master
Had not encountered operators like `_combine_dfs` initially, and had made an incorrect assumption about when to raise an exception
@danthedaniel
Copy link
Contributor Author

My bad on this one

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.332% when pulling 2f4b7b4 on teaearlgraycold:eu_imports_ref into 7910b93 on rhiever:master.

@rhiever
Copy link
Contributor

rhiever commented May 9, 2016

This is why we need unit tests. :-)

On Monday, May 9, 2016, Daniel notifications@github.com wrote:

My bad on this one


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#138 (comment)

Randal S. Olson, Ph.D.
Postdoctoral Researcher, Institute for Biomedical Informatics
University of Pennsylvania

E-mail: rso@randalolson.com | Twitter: @randal_olson
https://twitter.com/randal_olson
http://www.randalolson.com

@rhiever rhiever merged commit a0e84de into EpistasisLab:master May 10, 2016
@danthedaniel danthedaniel deleted the eu_imports_ref branch August 19, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants