-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored operators into separate classes to simplify TPOT class and future incorporation of new operators #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…All bugs not yet addressed, but saving work.
…t not actually be returning class assignments for some reason. Still, on the right track.
…tarting to figure this out. Also, add tpot/operators/operators_test.py which should have been added in previous commit.
…er model primitives to focus on the one model for development.
… the class name into the comment text.
…ocks mostlyg the way we should otherwise.
…mentally port each operator to the new object-oriented scheme.
…it method in _train_model_and_predict
…pected. Really need to sort out some unit tests for these operators.
… accept the input_DF (aka operator[2]) as a default input.
…nerOperator method in earlier commit.
…s into their own respective classes.
Thanks so much for this refactor! Since it'll require a fair amount of work to integrate, I'm going to hold off on merging this until mid-January or so when I'm done with the latest paper. |
@dmarx: Okay, now is probably the best time to try to merge this before I move on to the next paper. You have bandwidth to try to link it with the current TPOT version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #43,