SelectFwe added issue #56 #68
Conversation
| @@ -0,0 +1 @@ | |||
| tpot | |||
There was a problem hiding this comment.
Please remove all of these files listed in the .idea directory.
|
Thank you for this PR @kadarakos. This looks great! I commented on some of the lines of code to request some fixes before we merge it. |
|
Thanks for the suggestions! I apologize for the messy PR, but I'm not very experienced in contributing to projects on github :-). |
| @@ -113,7 +113,8 @@ def __init__(self, population_size=100, generations=100, | |||
| self.pset.addPrimitive(self.gradient_boosting, [pd.DataFrame, float, int, int], pd.DataFrame) | |||
| self.pset.addPrimitive(self._combine_dfs, [pd.DataFrame, pd.DataFrame], pd.DataFrame) | |||
| self.pset.addPrimitive(self._variance_threshold, [pd.DataFrame, float], pd.DataFrame) | |||
| self.pset.addPrimitive(self._select_kbest, [pd.DataFrame, int], pd.DataFrame) | |||
| self.pset.addPrimitive(self._select_kbest, [pd.DataFrame, int], pd.DataFrame) | |||
| self.pset.addPrimitive(self._select_fwe, [pd.DataFrame, int], pd.DataFrame) | |||
There was a problem hiding this comment.
Just noticed -- this should be
self.pset.addPrimitive(self._select_fwe, [pd.DataFrame, float], pd.DataFrame)since the second parameter that select_fwe() takes is the alpha value in the range [0.001, 0.05].
|
No worries -- I appreciate that you took the time to contribute! :-) I just noted one more minor error, which when fixed, I believe will make this PR ready to merge. |
|
Should I add anything else? |
|
Thank you for pinging me on this again! It's now merged. :-) |
Solving issue: Add SelectFwe to feature selection operators #56.
Code is based on the SelectKBest operator.