Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impute predict proba #718

Closed
wants to merge 20 commits into from
Closed

Impute predict proba #718

wants to merge 20 commits into from

Conversation

adithyabsk
Copy link
Contributor

What does this PR do?

Updates predict proba to impute values to prevent it from breaking from nan inputs.

Where should the reviewer start?

tpot/base.py
--> def predict_proba(self, features):
....

How should this PR be tested?

Try using a test input with nans in predict_proba

Any background context you want to provide?

Predict proba was breaking before this change.

What are the relevant issues?

None

Screenshots (if appropriate)

N/A

Questions:

  • Do the docs need to be updated?
    No
  • Does this PR add new (Python) dependencies?
    No

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.685% when pulling ca26160 on adithyabsk:impute-predict-proba into c92fea5 on EpistasisLab:master.

@adithyabsk
Copy link
Contributor Author

Accidentally merged dev into master... will resubmit pull request

@adithyabsk adithyabsk closed this Jun 25, 2018
@adithyabsk adithyabsk deleted the impute-predict-proba branch June 25, 2018 20:13
@adithyabsk adithyabsk restored the impute-predict-proba branch June 25, 2018 20:14
@adithyabsk adithyabsk deleted the impute-predict-proba branch July 19, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants