Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for IndexError #850

Closed
wants to merge 1 commit into from
Closed

Conversation

gstaron
Copy link

@gstaron gstaron commented Mar 22, 2019

Solves error: IndexError: boolean index did not match indexed array along dimension 0; dimension is [n] but corresponding boolean dimension is [n+1]

[please review the contribution guidelines prior to submitting your pull request. go ahead and delete this line if you've already reviewed said guidelines.]

What does this PR do?

Where should the reviewer start?

How should this PR be tested?

Any background context you want to provide?

What are the relevant issues?

[you can link directly to issues by entering # then the number of the issue, for example, #3 links to issue 3]

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated?
  • Does this PR add new (Python) dependencies?

Solves error: IndexError: boolean index did not match indexed array along dimension 0; dimension is 101 but corresponding boolean dimension is 102
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 96.123% when pulling 4f19729 on gstaron:patch-1 into c3f165b on EpistasisLab:master.

@weixuanfu
Copy link
Contributor

weixuanfu commented Mar 22, 2019

Thank you for this PR. I think this IndexError will raise if the categorical_features is assigned an array including a incorrect index or more. I think we need this IndexError message for letting user to check input array.

@weixuanfu
Copy link
Contributor

I closed this PR due to no response for a while. Please feel free to reopen it if you think this PR is needed.

@weixuanfu weixuanfu closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants