Remove space upgrade from DB upgrade #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The space upgrade relies on local files if the experiment's search space is defined in a configuration file. Parsing these file during the DB upgrade can break the DB because all experiments may not be executed on the same file system and thus some configuration files may not be present. The space should only be upgraded when the user attempts running an experiment, in which case the configuration file is available. The space does not need to be upgraded during DB upgrade anyway, because experiment built is backward compatible with experiments lacking an explicit space definition in DB (relying on cmdargs and config file to define space at run-time). How: Remove space upgrade from db upgrade script.
The DB upgrade does not update the space and priors anymore. The are handled anyway at runtime, no need to update them in the DB
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #554]
Why:
The space upgrade relies on local files if the experiment's search space
is defined in a configuration file. Parsing these file during the DB
upgrade can break the DB because all experiments may not be executed on
the same file system and thus some configuration files may not be
present. The space should only be upgraded when the user attempts
running an experiment, in which case the configuration file is available.
The space does not need to be upgraded during DB upgrade anyway, because
experiment built is backward compatible with experiments lacking an
explicit space definition in DB (relying on cmdargs and config file to
define space at run-time).
How:
Remove space upgrade from db upgrade script.