Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove space upgrade from DB upgrade #627

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Remove space upgrade from DB upgrade #627

merged 3 commits into from
Jul 23, 2021

Commits on Jul 23, 2021

  1. Remove space upgrade from DB upgrade 

    Why:

The space upgrade relies on local files if the experiment's search space
is defined in a configuration file. Parsing these file during the DB
upgrade can break the DB because all experiments may not be executed on
the same file system and thus some configuration files may not be
present. The space should only be upgraded when the user attempts
running an experiment, in which case the configuration file is available.

The space does not need to be upgraded during DB upgrade anyway, because
experiment built is backward compatible with experiments lacking an
explicit space definition in DB (relying on cmdargs and config file to
define space at run-time).

How:

Remove space upgrade from db upgrade script.
    @bouthilx
    bouthilx committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4a5092b View commit details
    Browse the repository at this point in the history

  2. Remove unused backward

    @bouthilx
    bouthilx committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b547fc9 View commit details
    Browse the repository at this point in the history

  3. Do not test for priors in backward comp tests 

    The DB upgrade does not update the space and priors anymore. The are
handled anyway at runtime, no need to update them in the DB
    @bouthilx
    bouthilx committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f557555 View commit details
    Browse the repository at this point in the history