-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework factory #681
Rework factory #681
Commits on Oct 6, 2021
-
Why: The meta-class factory was confusing and sometimes hard to debug. The factory should be a separate object that the constructors of the classes. When calling a class, we expect to receive an instance of the class, not of a child class. The factory also makes it simpler to add new features such as fetching class objects based on strings on grouping singleton instances per factory. How: Each class requiring the factory will be using ``Factory(base_class)`` as a factory to instantiate child classes. The explicit method ``factory.create()`` will be used instead of the confusing `MyFactory()`. Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f076b7 - Browse repository at this point
Copy the full SHA 3f076b7View commit details -
Convert Database and Storage to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 021351a - Browse repository at this point
Copy the full SHA 021351aView commit details -
Convert Strategy to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 14d52d2 - Browse repository at this point
Copy the full SHA 14d52d2View commit details -
Convert algo to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d543be0 - Browse repository at this point
Copy the full SHA d543be0View commit details -
Adapt benchmarking module to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a8f59d0 - Browse repository at this point
Copy the full SHA a8f59d0View commit details -
Adapt EVC Adapter to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 93a5fd9 - Browse repository at this point
Copy the full SHA 93a5fd9View commit details -
Convert converter (lol) to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5292ab0 - Browse repository at this point
Copy the full SHA 5292ab0View commit details -
Convert executor to GenericFactory
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52d93fe - Browse repository at this point
Copy the full SHA 52d93feView commit details
Commits on Oct 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9f1d2ae - Browse repository at this point
Copy the full SHA 9f1d2aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c6602a - Browse repository at this point
Copy the full SHA 9c6602aView commit details