Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework factory #681

Merged
merged 10 commits into from
Oct 22, 2021
Merged

Rework factory #681

merged 10 commits into from
Oct 22, 2021

Commits on Oct 6, 2021

  1. Add new Factory classes

    Why:
    
    The meta-class factory was confusing and sometimes hard to debug. The
    factory should be a separate object that the constructors of the
    classes. When calling a class, we expect to receive an instance of the
    class, not of a child class. The factory also makes it simpler to add
    new features such as fetching class objects based on strings on grouping
    singleton instances per factory.
    
    How:
    
    Each class requiring the factory will be using ``Factory(base_class)``
    as a factory to instantiate child classes. The explicit method
    ``factory.create()`` will be used instead of the confusing
    `MyFactory()`.
    
    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3f076b7 View commit details
    Browse the repository at this point in the history
  2. Convert Database and Storage to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    021351a View commit details
    Browse the repository at this point in the history
  3. Convert Strategy to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    14d52d2 View commit details
    Browse the repository at this point in the history
  4. Convert algo to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d543be0 View commit details
    Browse the repository at this point in the history
  5. Adapt benchmarking module to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    a8f59d0 View commit details
    Browse the repository at this point in the history
  6. Adapt EVC Adapter to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    93a5fd9 View commit details
    Browse the repository at this point in the history
  7. Convert converter (lol) to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    5292ab0 View commit details
    Browse the repository at this point in the history
  8. Convert executor to GenericFactory

    Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
    bouthilx and corneauf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    52d93fe View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Configuration menu
    Copy the full SHA
    9f1d2ae View commit details
    Browse the repository at this point in the history
  2. blackify

    bouthilx committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    9c6602a View commit details
    Browse the repository at this point in the history