Rework factory #681
Merged
Rework factory #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The meta-class factory was confusing and sometimes hard to debug. The factory should be a separate object that the constructors of the classes. When calling a class, we expect to receive an instance of the class, not of a child class. The factory also makes it simpler to add new features such as fetching class objects based on strings on grouping singleton instances per factory. How: Each class requiring the factory will be using ``Factory(base_class)`` as a factory to instantiate child classes. The explicit method ``factory.create()`` will be used instead of the confusing `MyFactory()`. Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
Co-authored-by: François Corneau-Tremblay <corneau90@gmail.com>
bouthilx
added
the
enhancement
Delaunay
approved these changes
Oct 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The meta-class factory was confusing and sometimes hard to debug. The
factory should be a separate object that the constructors of the
classes. When calling a class, we expect to receive an instance of the
class, not of a child class. The factory also makes it simpler to add
new features such as fetching class objects based on strings on grouping
singleton instances per factory.
How:
Each class requiring the factory will be using
Factory(base_class)as a factory to instantiate child classes. The explicit method
factory.create()will be used instead of the confusingMyFactory().