Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard/experiments/database page] New table framework #975

Merged
merged 4 commits into from
Jul 27, 2022
Merged

[dashboard/experiments/database page] New table framework #975

merged 4 commits into from
Jul 27, 2022

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a PR to use a new more featured table framework: https://tanstack.com/

Changes

  • Use new framework tanstack/react-table
  • Reimplement in new table:
    • short names for trial IDs
    • table sorting
  • Implement in new table:
    • grouped column for parameters
    • pagination (combined with carbon-react pagination component)
    • show/hide columns (use carbon-react multiselect component to choose displayed columns)

I guess a demo will be better to present changes ^^ !

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

bouthilx
bouthilx approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Jul 27, 2022
@bouthilx bouthilx merged commit 2a31867 into Epistimio:develop Jul 27, 2022
@notoraptor notoraptor deleted the new-table-framework branch August 1, 2022 15:51
@notoraptor notoraptor mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notoraptor @bouthilx