Major issue - safes can be looted even then locked (by anyone)

[eedijs]

Title says it all.

[RC-Robio]

This is also infistar related.

[infiSTAR]

I have nothing to do with that crap, what are you talking about?
Maybe some people updated their epoch servers and have somewhat old versions of the anti-hack which then changes / reverts functions? But nothing related to me :)

[uranoxyd]

Its not infistar related, there is a syntax error in https://github.com/EpochModTeam/Epoch/blob/master/Sources/epoch_server_settings/configs/security/security_checks.h line 67 producing this error:

14:45:35 Error in expression < [2, 3] || (_this select 1) getVariable['EPOCH_Locked;, false])>
14:45:35   Error position: <'EPOCH_Locked;, false])>
14:45:35   Error Fehlendes '

[infiSTAR]

Oh, good to know Uranoxyd.
I was just starting to look into it but apparently it is like always.. people that don't know what they are talking about spreading the word until everybody assumes false truth and errors never get fixed. Good you posted this so it can actually be fixed 👍

[infiSTAR]

What you posted there seems to be from that copy paste tool. There might be another issue with the safe locking as probably not everybody runs it

[RC-Robio]

That was my bad Chris. I do know what I am talking about. Didn't mean to jump the gun. I apologize.

[uranoxyd]

maybe, i just searched the codebase for 'EPOCH_Locked;, false and found this.

[MGTDB]

This is the error line in security_checks.h

InventoryOpened = "_this spawn EPOCH_initUI; (locked (_this select 1) in [2, 3] || (_this select 1) getVariable['EPOCH_Locked;, false])";

[infiSTAR]

no problem, sorry RC-Robio for being rude. You would not believe how many people emailed me today about that problem ^^

[infiSTAR]

btw for those who don't see the issue here. it is in

epoch_server_settings\configs\security\security_checks.h

InventoryOpened = "_this spawn EPOCH_initUI; (locked (_this select 1) in [2, 3] || (_this select 1) getVariable['EPOCH_Locked;, false])";

there is a ; behind EPOCH_Locked instead of a single quote '

should be this instead
InventoryOpened = "_this spawn EPOCH_initUI; (locked (_this select 1) in [2, 3] || (_this select 1) getVariable['EPOCH_Locked', false])";

[RC-Robio]

Pull Request created:
c359745

[Skaronator]

fixed via 34e8806

[uranoxyd]

It seems the wrong PBO was packed after the patch. The change was made in a3_epoch_server_settings and in the last commit for the Server_Install_Pack a3_epoch_server.pbo was changed not a3_epoch_server_settings.pbo. So, the bug remains :)

[vbawol]

Sorry about that guys, repacked the settings pbo and pushed build 053 https://github.com/EpochModTeam/Epoch/releases