-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use jdk 17 for artifact publish #69
Conversation
@@ -5,7 +5,7 @@ plugins { | |||
} | |||
|
|||
group = "cloud.eppo" | |||
version = "3.1.0" | |||
version = "3.2.0-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping to next version since I already ran the release locally
@@ -1,11 +1,12 @@ | |||
plugins { | |||
id 'com.android.library' | |||
id 'maven-publish' | |||
id 'signing' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was also missing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming it's ok to use JDK 17 to publish something that needs to be version 11 compatible. I assume it is, and that Java here is just being used to run publish tooling.
@aarsilv actually this version of the android gradle plugin requires java 17
|
Welp https://github.com/Eppo-exp/android-sdk/actions/runs/9571411350/job/26388786755