Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use jdk 17 for artifact publish #69

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

felipecsl
Copy link
Member

@@ -5,7 +5,7 @@ plugins {
}

group = "cloud.eppo"
version = "3.1.0"
version = "3.2.0-SNAPSHOT"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping to next version since I already ran the release locally

@@ -1,11 +1,12 @@
plugins {
id 'com.android.library'
id 'maven-publish'
id 'signing'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was also missing this

Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming it's ok to use JDK 17 to publish something that needs to be version 11 compatible. I assume it is, and that Java here is just being used to run publish tooling.

@felipecsl
Copy link
Member Author

@aarsilv actually this version of the android gradle plugin requires java 17

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.library']
> Failed to apply plugin 'com.android.internal.library'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /opt/hostedtoolcache/Java_Adopt_jdk/11.0.23-9/x64
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.

@felipecsl felipecsl merged commit eb80dd3 into main Jun 18, 2024
1 check passed
@felipecsl felipecsl deleted the felipecsl--publish-java-17 branch June 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants