-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
canGoPrev: false failing #124
Comments
cool !! thanks @mcicoria, I didn't notice that. I would be nice to have your PR for this part, thanks !! |
Closed
@mcicoria i'll leave this to you first, if you have any problem about making PR, please let me know ;) |
EragonJ
added a commit
that referenced
this issue
Dec 17, 2015
fixed #124, canGoPrev & canGoNext should work well
@mcicoria i just wrote the patch for you ! thanks for the information : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
trip.core.js:744 is
var canGoPrev = trip.canGoPrev || this.settings.canGoPrev;
If you choose to set canGoPrev to false, then this statement sets it back to the default setting of true.
This is also the case with trip.core.js:762
var canGoNext = trip.canGoNext || this.settings.canGoNext;
I'm happy to send a pull request to change them to:
The text was updated successfully, but these errors were encountered: