Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canGoPrev: false failing #124

Closed
mcicoria opened this issue Dec 8, 2015 · 3 comments
Closed

canGoPrev: false failing #124

mcicoria opened this issue Dec 8, 2015 · 3 comments

Comments

@mcicoria
Copy link
Contributor

mcicoria commented Dec 8, 2015

trip.core.js:744 is

var canGoPrev = trip.canGoPrev || this.settings.canGoPrev;

If you choose to set canGoPrev to false, then this statement sets it back to the default setting of true.

This is also the case with trip.core.js:762

var canGoNext = trip.canGoNext || this.settings.canGoNext;

I'm happy to send a pull request to change them to:

 var canGoNext = trip.canGoNext;
 if(typeof canGoNext === "undefined") {
    canGoNext = this.settings.canGoNext; 
}
...

 var canGoPrev = trip.canGoPrev;
 if(typeof canGoPrev === "undefined") {
    canGoPrev = this.settings.canGoPrev; 
}
...
@EragonJ
Copy link
Owner

EragonJ commented Dec 9, 2015

cool !! thanks @mcicoria, I didn't notice that. I would be nice to have your PR for this part, thanks !!

@EragonJ
Copy link
Owner

EragonJ commented Dec 9, 2015

@mcicoria i'll leave this to you first, if you have any problem about making PR, please let me know ;)

EragonJ added a commit that referenced this issue Dec 17, 2015
fixed #124, canGoPrev & canGoNext should work well
@EragonJ
Copy link
Owner

EragonJ commented Dec 17, 2015

@mcicoria i just wrote the patch for you ! thanks for the information : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants