Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async channels #236

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Async channels #236

merged 7 commits into from
Apr 30, 2024

Conversation

lucasavila00
Copy link
Contributor

Closes #235

Copy link

github-actions bot commented Apr 28, 2024

Code Metrics Report
  ───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
Rust                        70     23673     1557       511    21605       1311
───────────────────────────────────────────────────────────────────────────────
Total                       70     23673     1557       511    21605       1311
───────────────────────────────────────────────────────────────────────────────
Estimated Cost to Develop 80,577
Estimated Schedule Effort 11.882489 months
Estimated People Required 5.088453
───────────────────────────────────────────────────────────────────────────────
Processed 782816 bytes, 0.783 megabytes (SI)
───────────────────────────────────────────────────────────────────────────────
  

@lucasavila00 lucasavila00 marked this pull request as ready for review April 28, 2024 04:43
@lucasavila00
Copy link
Contributor Author

lucasavila00 commented Apr 28, 2024

I tested the server, interactive mode, quantized example, benchmark.

I think these cover all of the APIs?

@EricLBuehler
Copy link
Owner

@lucasavila00, thank you. Can you please test the Python bindings? It also seems like there are some more merge conflicts.

@lucasavila00
Copy link
Contributor Author

lucasavila00 commented Apr 28, 2024

@EricLBuehler I fixed the conflitcts and tested the python api.

@EricLBuehler EricLBuehler added the new feature New feature or request label Apr 30, 2024
@EricLBuehler EricLBuehler merged commit dd8ffc6 into EricLBuehler:master Apr 30, 2024
8 of 11 checks passed
@EricLBuehler
Copy link
Owner

@lucasavila00 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axum server blocking - Add async channels
2 participants