Fix quantized example #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report─────────────────────────────────────────────────────────────────────────────── Language Files Lines Blanks Comments Code Complexity ─────────────────────────────────────────────────────────────────────────────── Rust 70 23339 1550 508 21281 1281 ─────────────────────────────────────────────────────────────────────────────── Total 70 23339 1550 508 21281 1281 ─────────────────────────────────────────────────────────────────────────────── Estimated Cost to Develop 69,864 Estimated Schedule Effort 11.811066 months Estimated People Required 5.038645 ─────────────────────────────────────────────────────────────────────────────── Processed 768517 bytes, 0.769 megabytes (SI) ─────────────────────────────────────────────────────────────────────────────── |
lucasavila00
commented
Apr 28, 2024
| stop_toks: None, | ||
| max_len: None, | ||
| logits_bias: None, | ||
| n_choices: 1, |
There was a problem hiding this comment.
it was defaulting to 0
There was a problem hiding this comment.
I'm not sure if this should use the Completion Request best_of instead. These 2 sources of truth are confusing
There was a problem hiding this comment.
@lucasavila00 the best_of parameter sets the number of seqs to consider when they are done by cumulative logprob. It should be <= n_choices.
EricLBuehler
approved these changes
Apr 28, 2024
| stop_toks: None, | ||
| max_len: None, | ||
| logits_bias: None, | ||
| n_choices: 1, |
There was a problem hiding this comment.
@lucasavila00 the best_of parameter sets the number of seqs to consider when they are done by cumulative logprob. It should be <= n_choices.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it while testing #236