Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed virtualenv and requirements issue #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed virtualenv and requirements issue #5

wants to merge 1 commit into from

Conversation

p0licat
Copy link

@p0licat p0licat commented Jun 22, 2019

This fixes #3

Copy link
Owner

@EricRubl EricRubl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good updates 💯 Fix the changes to merge them.

@@ -1,9 +1,49 @@
"""
Uncomment lines before merge to confirm behavior is as expected.
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do that 😂

#cp *.py /etc/digitalocean-dns-updater

# ETC lines not changed! assuming ./lib is used
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See what is to be uncommented here so that also the daemon gets installed and started

Copy link
Author

@p0licat p0licat Jun 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test in qemu and commit. See Issue comment #3 (comment)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@EricRubl EricRubl changed the title fixed virtualenv and requirements issue Fixed virtualenv and requirements issue Jun 22, 2019
@EricRubl EricRubl added the enhancement New feature or request label Jun 22, 2019
@EricRubl
Copy link
Owner

EricRubl commented Nov 23, 2019

@p0licat any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create venv in installation process
2 participants