-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested ternary operator does not work when object plugin is used #183
Comments
Thanks for reporting @untersalmberger . I can see the issue and will try to fix it sometime this weekend :) |
You guys are amazing! I love your work! |
The object plugin adds a `:` binary operator which interferes with ternaries. The previous version would work with both objects and ternaries, but not when nested without parentheses. Fixes cases like, `a ? 0 : b ? 1 : 2` and similar. Fixes #183
Thank you for fixing this! |
🎉 This issue has been resolved in version @jsep-plugin/object-v1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [@jsep-plugin/ternary-v1.0.1](https://github.com/EricSmekens/jsep/compare/@jsep-plugin/ternary-v1.0.0...@jsep-plugin/ternary-v1.0.1) (2021-10-03) ### Bug Fixes * support nested ternaries with the object plugin loaded ([cf37c29](cf37c29)), closes [#183](#183)
🎉 This issue has been resolved in version @jsep-plugin/ternary-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
(also jsep@v1.1.0, since that includes the ternary plugin by default) |
When the
object
plugin is registered, a nested ternary operator no longer works. jsep throws an exception that it expects a:
at some position.That's what works without the
object
plugin, but not with theobject
plugin:Other plugins like the
comment
plugin do not harm.Looks like an "unresolved technical issue" :)
The text was updated successfully, but these errors were encountered: